NFC: CMake: Runtime build housekeeping #84741
Merged
+53
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small refactor to rename the build module directory,
"${CMAKE_CURRENT_BINARY_DIR}/${module_name}.swiftmodule" to
"${module_directory}" to make it more concise.
Adding the additional driver outputs in the cleanup files. This cleans up the warnings from `ninja clean`. ``` Cleaning... ninja: error: remove(clang/_Builtin_float.swiftmodule): Directory not empty ```
etcwilde
requested review from
compnerd,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
compnerd
approved these changes
Oct 7, 2025
Updating the todo list comments. - Windows builds are already using the runtime build system to build the runtimes so we can remove that from the todo list. - The Android SDK on Windows is currently cross-compiled with the new runtime build. - Catalyst builds have been going for a bit now, generating the necessary bits. - We moved things to a nested swiftmodule structure, which installs the entire directory, containing all of the emitted products. The Glibc Linux builds should be coming soon. We still have embedded to work on.
etcwilde
force-pushed
the
ewilde/runtimes-fix-cleanups
branch
from
69cf313 to
989b3be
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some housekeeping and cleanups.
Updating the Todo comments on SwiftCore to be more accurate about where things stand. Really the main thing remaining are the embedded builds.
Then doing some cleanups regarding the swift module emission. The swiftmodule directory was being used in several places so I factored that out into a separate variable to make things a bit more readable. Also added the supplemental module outputs to the list of cleanup files so that running
ninja cleanwill work without warning about the swiftmodule directory containing files.