[Evaluator] Enforce consistent results for cyclic requests #84745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
AnthonyLatsis,
CodaFi,
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
slavapestov
approved these changes
Oct 7, 2025
Factor out the common logic from `getPlaceholderGenericSignature`.
Avoid conformance failures and member lookup errors for generic signatures with invalid same-type requirements.
This helps avoid producing more downstream errors. This changes `GenericSignature::forInvalid` to produce the same signature as e.g `<T where T == Undefined>`. This subsumes the need to introduce conformance requirements for invertible protocols.
Record when we encounter a request cycle, and enforce that the outer step of the cycle also returns the default value. This fixes a couple of crashers where we were ending up with conflicting values depending on whether the request was queried from within the cycle or from outside it.
Remove the now-unnecessary hack where we could build recursive ErrorTypes.
Avoid type-checking the `where` clause when computing the interface type of a variable bound in the pattern of the loop as otherwise that will trigger cycles and give us an ErrorType result.
hamishknight
force-pushed
the
fishmonger
branch
from
22e1cfa to
2ce7f1c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please SourceKit stress test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record when we encounter a request cycle, and enforce that the outer step of the cycle also returns the default value. This fixes a couple of crashers where we were ending up with conflicting values depending on whether the request was queried from within the cycle or from outside it. This also allows us to flatten recursive ErrorTypes, which were previously load-bearing.
To help avoid additional downstream diagnostics for recursive generic signature computation, this PR also changes the placeholder generic signature logic to use same-type ErrorType requirements, and adds a checks to avoid downstream diagnostics in type resolution and conformance checking.
Resolves #57045