[update-checkout] fallback to verbose mode if tempdir is too long #84762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
charles-zablit
added
utils
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test |
adrian-prantl
approved these changes
Oct 8, 2025
| self.assertIn(b"git checkout refs/heads/main", output) | ||
|
|
||
| def test_manager_not_called_on_long_socket(self): | ||
| fake_tmpdir = '/tmp/very/' + '/long' * 20 + '/tmp' |
There was a problem hiding this comment.
I was going to say, we shouldn't hardcode /tmp, but this is just a random long path, that isn't being accessed, right? You're using https://docs.python.org/3/library/tempfile.html to get a real directory?
There was a problem hiding this comment.
Yes, this is just a random long path to emulate a path with more than ~100 characters.
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum path size for a Unix socket on macOS is
104bytes (108on Linux). This causesupdate-checkoutto fail in silent mode whenTMPDIRis set to a long path. This is likely to happen in CI.This patch checks if the socket path will exceed the limit and fallback to
verbosemode if it does.verbosemode does not use aManagerand therefore does not create a socket. The patch also adds a unittest to make sure we never try to create a Manager if the TMPDIR path is too long.rdar://162088344