Fix std::span tests on linux #84774
Open
Fix std::span tests on linux #84774
+19
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
egorzhdan,
fahadnayyar,
j-hui,
susmonteiro and
zoecarver
as code owners
j-hui
approved these changes
Oct 8, 2025
|
preset=buildbot_linux |
hnrklssn
force-pushed
the
fix-std-span-linux
branch
from
b7bcd95 to
dd34be4
Compare
|
preset=buildbot_linux |
|
@swift-ci please test |
Xazax-hun
approved these changes
Oct 9, 2025
hnrklssn
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
This adds a check in CMake for whether the current C++ stdlib contains the 'span' header. If so, the llvm-lit feature 'std_span' is set. Also adds 'REQUIRES: std_span' to interop tests that include 'span'. This means we no longer have to choose between blanket disabling `std::span` tests on all Linux distributions, or listing every Linux distro with a libstdc++ version without `std::span` support as unsupported. rdar://161999160 rdar://161999174 rdar://162106580 rdar://162106619 rdar://162106643 rdar://162106653 rdar://162106722 rdar://162106747
hnrklssn
force-pushed
the
fix-std-span-linux
branch
from
ca22113 to
edf402d
Compare
|
@swift-ci please smoke test |
hnrklssn
commented
Oct 10, 2025
| endif() | ||
|
|
||
| include(CheckIncludeFileCXX) | ||
| check_include_file_cxx("span" HAVE_STD_SPAN) |
There was a problem hiding this comment.
@etcwilde @egorzhdan Could you check my logic here - is this approach sound? Or does this need to be checked for every test target? Is CMake aware of multiple different SDKs when testing multiple different targets?
Perhaps I'm overthinking it - I never use multiple test targets, so that feature is a bit outside my wheelhouse. I can't think of a case where we would realistically test against one target without std::span and one with, but I thought I'd highlight it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.