[Concurrency] Adopt typed throws in Task creation APIs #84802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
added
swift evolution pending discussion
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-task-init-typed-throws
branch
from
b483a47 to
ea17a92
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Comment on lines
-192
to
+196
| return .failure(error as! Failure) // as!-safe, guaranteed to be Failure | ||
| return .failure(error) // as!-safe, guaranteed to be Failure |
There was a problem hiding this comment.
Comment now refers to a force cast that has moved elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending SE evolution: swiftlang/swift-evolution#2990
This makes Task.init and friends adopt typed throws, and also drops discardable result from the throwing APIs