Skip to content

[AST] Simplify Type::isBareErrorType #84804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

[AST] Simplify Type::isBareErrorType #84804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions include/swift/AST/Types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8132,13 +8132,7 @@ inline ASTContext &TypeBase::getASTContext() const {

inline bool TypeBase::isBareErrorType() const {
auto *errTy = dyn_cast<ErrorType>(this);
if (!errTy)
return false;

// FIXME: We shouldn't need to check for a recursive bare error type, we can
// remove this once we flatten them.
auto originalTy = errTy->getOriginalType();
return !originalTy || originalTy->isBareErrorType();
return errTy && !errTy->getOriginalType();
}

// TODO: This will become redundant once InOutType is removed.
Expand Down