CMake: allow to specify a SDK when building a triple for Embedded Swift #84817
+19
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To achieve so, allow each item in `SWIFT_EMBEDDED_STDLIB_EXTRA_TARGET_TRIPLES` to append a SDK path after a @ character, e.g. ``` -DSWIFT_EMBEDDED_STDLIB_EXTRA_TARGET_TRIPLES=aarch64-vendor-os@/usr/local/aarch64-vendor-os-sdk;aaarch-vendor-anotheros ``` Addresses rdar://162368529
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
edymtt
commented
Oct 10, 2025
| list(LENGTH triple_configuration_list triple_configuration_list_length) | ||
| if(triple_configuration_list_length GREATER_EQUAL 2) | ||
| list(GET triple_configuration_list 1 sdk_path) | ||
| set(EMBEDDED_STDLIB_SDK_FOR_${triple} "${sdk_path}") |
There was a problem hiding this comment.
This is causing the failure in Linux and Windows bots, since I am overwriting the values for SWIFT_SDK_embedded_ARCH_wasm32_PATH and SWIFT_SDK_embedded_ARCH_wasm32-unknown-wasip1_PATH that are passed directly to CMake.
[2025-10-10T19:30:49.072Z] FAILED: stdlib/public/Concurrency/CMakeFiles/embedded-concurrency-default-executor-wasm32-unknown-wasip1.dir/CooperativeGlobalExecutor.cpp.o
[2025-10-10T19:30:49.072Z] /home/build-user/swift-nightly-install/usr/bin/clang++ ... --sysroot= ...
[2025-10-10T19:30:49.072Z] clang++: warning: argument unused during compilation: '-fno-semantic-interposition' [-Wunused-command-line-argument]
[2025-10-10T19:30:49.072Z] /home/build-user/swift/stdlib/public/Concurrency/CooperativeGlobalExecutor.cpp:33:10: fatal error: 'chrono' file not found
[2025-10-10T19:30:49.072Z] 33 | #include <chrono>
[2025-10-10T19:30:49.072Z] | ^~~~~~~~
[2025-10-10T19:30:49.072Z] 1 error generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve so, allow each item in
SWIFT_EMBEDDED_STDLIB_EXTRA_TARGET_TRIPLESto append a SDK path after a @ character, e.g.PIggyback a fix to correctly support triples that specify an environment.
Addresses rdar://162368529