Skip to content

Reenable some raw buffer tests in release build. #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Reenable some raw buffer tests in release build. #8616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 17 additions & 56 deletions test/stdlib/UnsafeRawBufferPointer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,16 +231,11 @@ UnsafeRawBufferPointerTestSuite.test("inBounds") {
expectEqualSequence(firstHalf, secondHalf)
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.get.underflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.get.underflow") {
let buffer = UnsafeMutableRawBufferPointer.allocate(count: 2)
defer { buffer.deallocate() }

let bytes = buffer[1..<2]
let bytes = UnsafeRawBufferPointer(rebasing: buffer[1..<2])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -249,16 +244,11 @@ UnsafeRawBufferPointerTestSuite.test("subscript.get.underflow")
_ = bytes[-1]
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.get.overflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.get.overflow") {
let buffer = UnsafeMutableRawBufferPointer.allocate(count: 2)
defer { buffer.deallocate() }

let bytes = buffer[0..<1]
let bytes = UnsafeRawBufferPointer(rebasing: buffer[0..<1])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -267,16 +257,11 @@ UnsafeRawBufferPointerTestSuite.test("subscript.get.overflow")
_ = bytes[1]
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.set.underflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.set.underflow") {
let buffer = UnsafeMutableRawBufferPointer.allocate(count: 2)
defer { buffer.deallocate() }

var bytes = buffer[1..<2]
var bytes = UnsafeMutableRawBufferPointer(rebasing: buffer[1..<2])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -285,16 +270,11 @@ UnsafeRawBufferPointerTestSuite.test("subscript.set.underflow")
bytes[-1] = 0
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.set.overflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.set.overflow") {
let buffer = UnsafeMutableRawBufferPointer.allocate(count: 2)
defer { buffer.deallocate() }

var bytes = buffer[0..<1]
var bytes = UnsafeMutableRawBufferPointer(rebasing: buffer[0..<1])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -303,16 +283,11 @@ UnsafeRawBufferPointerTestSuite.test("subscript.set.overflow")
bytes[1] = 0
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.range.get.underflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.range.get.underflow") {
let buffer = UnsafeMutableRawBufferPointer.allocate(count: 3)
defer { buffer.deallocate() }

let bytes = buffer[1..<3]
let bytes = UnsafeRawBufferPointer(rebasing: buffer[1..<3])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -321,16 +296,11 @@ UnsafeRawBufferPointerTestSuite.test("subscript.range.get.underflow")
_ = bytes[-1..<1]
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.range.get.overflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.range.get.overflow") {
let buffer = UnsafeMutableRawBufferPointer.allocate(count: 3)
defer { buffer.deallocate() }

let bytes = buffer[0..<2]
let bytes = UnsafeRawBufferPointer(rebasing: buffer[0..<2])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -339,16 +309,11 @@ UnsafeRawBufferPointerTestSuite.test("subscript.range.get.overflow")
_ = bytes[1..<3]
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.range.set.underflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.range.set.underflow") {
var buffer = UnsafeMutableRawBufferPointer.allocate(count: 3)
defer { buffer.deallocate() }

var bytes = buffer[1..<3]
var bytes = UnsafeMutableRawBufferPointer(rebasing: buffer[1..<3])

if _isDebugAssertConfiguration() {
expectCrashLater()
Expand All @@ -357,16 +322,12 @@ UnsafeRawBufferPointerTestSuite.test("subscript.range.set.underflow")
bytes[-1..<1] = bytes[0..<2]
}

// FIXME: rdar:31495442. Enable this in release builds too.
UnsafeRawBufferPointerTestSuite.test("subscript.range.set.overflow")
.skip(.custom(
{ !_isDebugAssertConfiguration() },
reason: "This tests a debug precondition."))
.code {
UnsafeRawBufferPointerTestSuite.test("subscript.range.set.overflow") {
var buffer = UnsafeMutableRawBufferPointer.allocate(count: 3)
defer { buffer.deallocate() }

var bytes = buffer[0..<2]
var bytes = UnsafeMutableRawBufferPointer(rebasing: buffer[0..<2])

if _isDebugAssertConfiguration() {
expectCrashLater()
}
Expand Down