Skip to content

Fix DeadStoreElim by not lying about instruction semantics #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Fix DeadStoreElim by not lying about instruction semantics #8651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/swift/SIL/SILNodes.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ ABSTRACT_VALUE(SILInstruction, ValueBase)

// Metatypes
INST(MetatypeInst, SILInstruction, metatype, None, DoesNotRelease)
INST(ValueMetatypeInst, SILInstruction, value_metatype, None, DoesNotRelease)
INST(ValueMetatypeInst, SILInstruction, value_metatype, MayRead, DoesNotRelease)
INST(ExistentialMetatypeInst, SILInstruction, existential_metatype, MayRead, DoesNotRelease)
INST(ObjCProtocolInst, SILInstruction, objc_protocol, None, DoesNotRelease)

Expand Down
16 changes: 16 additions & 0 deletions test/SILOptimizer/dead_store_elim.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,3 +1417,19 @@ bb0(%0 : $AB): // Preds: bb6 bb5 bb4 bb3
dealloc_stack %1 : $*AB
return %2 : $Builtin.Int1
}

// CHECK-LABEL: dont_remove_store
// CHECK: load
// CHECK: store
// CHECK: value_metatype
// CHECK: return
sil @dont_remove_store : $@convention(thin) (@in_guaranteed foo) -> () {
bb0(%0 : $*foo):
%1 = alloc_stack $foo
%2 = load %0 : $*foo
store %2 to %1 : $*foo
%3 = value_metatype $@thick foo.Type, %1 : $*foo
dealloc_stack %1 : $*foo
%20 = tuple()
return %20 : $()
}