Test suites in nested extensions have incorrect parent in test explorer #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because swift-testing suites can be defined through nested extensions the tests provided might not be directly parented to the test target. For instance, the test target might be `Foo`, and one of the child `testItems` in the document tests response might be `Foo.Bar/Baz`. If we simply attach the `testItems` to the root test target then the intermediate suite `Bar` will be dropped. To avoid this, syntheize the intermediate children just like we synthesize the test target.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because swift-testing suites can be defined through nested extensions the tests provided might not be directly parented to the test target. For instance, the test target might be
Foo, and one of the childtestItemsin the document tests response might beFoo.Bar/Baz. If we simply attach thetestItemsto the root test target then the intermediate suiteBarwill be dropped. To avoid this, syntheize the intermediate children just like we synthesize the test target.