Mock settings writes in ToolchainSelection tests #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `should show open dialog for folder selection` test would write the selected toolchain value into settings. This would break the integration tests if you ran them after the unit tests because the location of `swift` would be incorrect.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
approved these changes
Sep 9, 2025
matthewbastien
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
should show open dialog for folder selectiontest would write the selected toolchain value into settings. This would break the integration tests if you ran them after the unit tests because the location ofswiftwould be incorrect.Tasks
Documentation has been updatedAdded an entry to CHANGELOG.md if applicable