Fix withKnownIssue not marking test as skipped in nightly toolchains #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of issue severity, the issue payload contains the flag `isFailure`. If this is true, we were assuming that the issue didn't meet the severity threshold. However if an issue is skipped with `withKnownIssue`, `isFailure` would be false but `isKnown` is true. In this case we still want to record the issue and have the test be marked as skipped.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of issue severity, the issue payload contains the flag
isFailure. If this is false, we were assuming that the issue didn't meet the severity threshold.However if an issue is skipped with
withKnownIssue,isFailurewould be false butisKnownis true. In this case we still want to record the issue and have the test be marked as skipped.Tasks
Required tests have been writtenDocumentation has been updatedAdded an entry to CHANGELOG.md if applicable