Allow setting the Swiftly toolchain at the workspace level #1860
+480
−445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
0xTim,
adam-fowler and
award999
as code owners
award999
reviewed
Sep 29, 2025
matthewbastien
force-pushed
the
swiftly-use
branch
from
bab8458 to
1abecae
Compare
matthewbastien
force-pushed
the
swiftly-use
branch
from
1abecae to
fb07f34
Compare
award999
reviewed
Sep 30, 2025
| toolchainPath => ({ | ||
| const swiftlyToolchains = (await Swiftly.list(logger)) | ||
| // Sort in descending order alphabetically | ||
| .sort((a, b) => -a.localeCompare(b)) |
There was a problem hiding this comment.
wouldn't that put 5.10 before 5.9?
award999
approved these changes
Sep 30, 2025
|
Unrelated test failure. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Respect the user's configuration selection when invoking
swiftly use. If the user selects the workspace configuration then the toolchain will be updated via the.swift-versionfile in the workspace (and if one isn't there it will be created). For global toolchains the--global-defaultoption will be set so that the toolchain gets updated globally.Issue: #1848
Tasks
[ ] Documentation has been updated[ ] Added an entry to CHANGELOG.md if applicableSwiftly is a new feature that hasn't made it into a release yet. No need to update change log.