Filter out incompatible additionalTestArgs when building tests for debugging #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
debugging When debugging tests we were appending `additionalTestArgs` to the build invocation. If the user has any incompatible flags that work for `swift test` but not `swift build`, this invocation will fail (i.e. `--no-parallel`). Filter down `additionalTestArgs` when performing the build to only `swift build` compatible arguments. All `additionalTestArgs` are still passed to the executable when tests are run. Issue: swiftlang#1863
plemarquand
force-pushed
the
no-test-args-for-builds
branch
from
20ca435 to
e00461c
Compare
matthewbastien
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When debugging tests we were appending
additionalTestArgsto the build invocation. If the user has any incompatible flags that work forswift testbut notswift build, this invocation will fail (i.e.--no-parallel).Filter down
additionalTestArgswhen performing the build to onlyswift buildcompatible arguments. AlladditionalTestArgsare still passed to the executable when tests are run.Issue: #1863
Tasks