Skip to content

Conversation

plemarquand
Copy link
Contributor

@plemarquand plemarquand commented Sep 30, 2025

Description

Provide more robust logs during extension activation/deactivation in order to help track down test timeouts. These logs are only printed if a test fails to avoid cluttering up the test report.

This additional logging uncovered several test related issues:

  • A background compilation task could have started after the BackgroundCompilation object was disposed
  • TaskQueues were not disposed and would continue to process tasks after the parent TaskManager was disposed
  • DYLD_FRAMEWORK_PATH/DYLD_LIBRARY_PATH should be set in the environment when debugging test both kinds of test executables on >=6.2
  • The FolderContexts created in FolderContext.test.ts were not being disposed, causing their BackgroundCompilation to run at undesirable times
  • The LanguageClientIntegration suite setup was doing a build all with test discovery enabled. Because the LSP isn't yet configured at this point, the extension would fall back to trying to discover tests with swift test --list-tests unexpectedly.
  • The ProjectPanelProvider did not dispose its listeners, and was not always being disposed correctly in the tests.

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

Provide more robust logs during extension activation/deactivation in
order to help track down test timeouts. These logs are only printed if a
test fails to avoid cluttering up the test report.
@plemarquand plemarquand added the full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit label Oct 2, 2025
@plemarquand plemarquand force-pushed the improve-test-logging branch from 204f5d0 to d25f887 Compare October 2, 2025 15:39
@plemarquand plemarquand force-pushed the improve-test-logging branch from a79d082 to 6347e3e Compare October 2, 2025 23:01
@plemarquand plemarquand force-pushed the improve-test-logging branch from 2941d93 to 4c91308 Compare October 3, 2025 20:36
@plemarquand plemarquand force-pushed the improve-test-logging branch from c7045eb to 7f29805 Compare October 4, 2025 16:07
@plemarquand plemarquand merged commit 7829093 into swiftlang:main Oct 6, 2025
129 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants