Allow writing to different sourcekit output channels #883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-server-bot test this please |
adam-fowler
reviewed
Jun 13, 2024
| client.onNotification(langclient.LogMessageNotification.type, params => { | ||
| const sourceKitParams = params as SourceKitLogMessageParams; | ||
| if (sourceKitParams.logName) { | ||
| const outputChannel = |
There was a problem hiding this comment.
Can we create the log channels in advance. We should know what logs SourceKit-LSP is going to want to open.
There was a problem hiding this comment.
After a chat will Alex, he asked if we could show timestamp but not log level for the Indexing log because it will always be info. So, for known logs like that, I'm letting set that configuration on startup. My idea behind allowing unknown logs to be created is if sourcekit-LSP changes, for development or as a user, they don't need to wait for an extension release to see the new log. Let me know if you still have concerns
Issue: swiftlang#833 IFF sourcekit logMessage notification includes a logName property, we'll use a different output channel to not polute the langauge server's main log. For a known list of logs we'll set them up on startup so we can control if the log level and/or timestamp is included in the log message. For the current known indexing log, for example, all messages will be "Info" so we'll just add timestamp. If new logs are introduced, we'll show log level and timestamp by default
award999
force-pushed
the
sourcekit-outputchannels
branch
from
b492697 to
2e29ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #833
IFF sourcekit logMessage notification includes a logName property, we'll
use a different output channel to not polute the langauge server's main
log. For a known list of logs we'll set them up on startup so we can
control if the log level and/or timestamp is included in the log message.
For the current known indexing log, for example, all messages will be
"Info" so we'll just add timestamp. If new logs are introduced, we'll
show log level and timestamp by default