Use @vscode/test-cli to run tests #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
force-pushed
the
vscode-test-cli
branch
2 times, most recently
from
602bcd9 to
7732978
Compare
|
I have this setup with my WIP for unit testing, I'll push that and we can reconcile this patch with that |
|
@award999 ah, sorry I didn't realize you already had some code going for this. I wrote most of this a while ago and revived it after seeing @matthewbastien getting those SIGSEGV errors in CI hoping this would help. |
NP, that patch will take longer to get in so let's use this one for just the test runner portion |
plemarquand
force-pushed
the
vscode-test-cli
branch
from
7732978 to
5fe44a7
Compare
Migrates to the new @vscode/test-cli package to download the appropriate VS Code and run the tests. This streamlines the test setup code, and should be a more reliable way to run the tests as VS Code evolves. Hopefully this also helps with the occasional SIGSEGV errors that happen in CI on startup.
plemarquand
force-pushed
the
vscode-test-cli
branch
from
5fe44a7 to
7997b15
Compare
award999
approved these changes
Jul 3, 2024
|
Thanks @award999 for sharing the code you’d written for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates to the new @vscode/test-cli package to download the appropriate VS Code and run the tests. This streamlines the test setup code, and should be a more reliable way to run the tests as VS Code evolves.
Hopefully this also helps with the occasional SIGSEGV errors that happen in CI on startup.