Skip to content

Remove outdated BigInt support FIXME from JSTypedArray #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

Remove outdated BigInt support FIXME from JSTypedArray #187

merged 1 commit into from
May 2, 2022

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented May 2, 2022 •
edited
Loading

The linked issue has already been closed, so this comment doesn't seem to be relevant.

@MaxDesiatov
Remove outdated BigInt support FIXME from JSTypedArray
4d70418 
The link issue has already been closed, so this comment doesn't seem to be relevant.
@MaxDesiatov MaxDesiatov added the documentation Improvements or additions to documentation label May 2, 2022
@MaxDesiatov MaxDesiatov requested a review from a team May 2, 2022 13:06
@github-actions
Copy link

github-actions bot commented May 2, 2022

Time Change: +571ms (3%)

Total Time: 17,767ms

Test name Duration Change
Object heap/Increment and decrement RC 5,357ms +416ms (7%) 🔍
View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 392ms +15ms (3%)
Serialization/Write JavaScript string directly 428ms +12ms (2%)
Serialization/Swift Int to JavaScript 5,742ms +59ms (1%)
Serialization/Swift String to JavaScript 5,848ms +68ms (1%)

@MaxDesiatov MaxDesiatov merged commit e858322 into main May 2, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/outdated-fixme branch May 2, 2022 13:26
@kateinoigakukun kateinoigakukun mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDesiatov @kateinoigakukun