Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharedMemory option to allow threads with shared memory #247

Merged
merged 4 commits into from
May 27, 2024

Conversation

kateinoigakukun
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 27, 2024

Time Change: +230ms (2%)

Total Time: 9,278ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 18ms -1ms (6%)
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 14ms -0ms
Serialization/JavaScript function call from Swift 92ms -3ms (3%)
Serialization/Swift Int to JavaScript with assignment 320ms -4ms (1%)
Serialization/Swift Int to JavaScript with call 926ms +13ms (1%)
Serialization/JavaScript Number to Swift Int 299ms -1ms (0%)
Serialization/Swift String to JavaScript with assignment 375ms +1ms
Serialization/Swift String to JavaScript with call 980ms +17ms (1%)
Serialization/JavaScript String to Swift String 3,614ms +142ms (3%)
Object heap/Increment and decrement RC 2,628ms +67ms (2%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 2ms
Serialization/Call with JavaScript string directly 2ms

This is a workaround for the issue that the argv0 program path
containing a symlink directory in the path causes `Bundle.main` to
crash.
@kateinoigakukun kateinoigakukun marked this pull request as ready for review May 27, 2024 12:38
@kateinoigakukun kateinoigakukun merged commit ea06982 into main May 27, 2024
16 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/thread-support branch May 27, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant