Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JSValueConvertible/Constructible/Codable #88

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Rename JSValueConvertible/Constructible/Codable #88

merged 4 commits into from
Oct 2, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Oct 1, 2020

Fixes #87.

@j-f1 j-f1 added the enhancement New feature or request label Oct 1, 2020
@j-f1 j-f1 mentioned this pull request Oct 1, 2020
Closed
@github-actions
Copy link

github-actions bot commented Oct 1, 2020 •
edited
Loading

Time Change: +960.75ms (6%) 🔍

Total Time: 14,198ms

Test name Duration Change
Serialization/Swift Int to JavaScript 5,045ms +258.5ms (5%) 🔍
Serialization/Swift String to JavaScript 5,451.5ms +465.25ms (8%) 🔍
Object heap/Increment and decrement RC 3,346.25ms +238.5ms (7%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 172.25ms -5ms (2%)
Serialization/Write JavaScript string directly 183ms +3.5ms (1%)

performance-action

MaxDesiatov
MaxDesiatov approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@j-f1 j-f1 changed the title JSValueConstructible → ConvertibleToJSValue & JSValueConvertible → ConstructibleFromJSValue Rename JSValueConvertible/Constructible/Codable Oct 2, 2020
@j-f1 j-f1 merged commit bbc49d3 into main Oct 2, 2020
@j-f1 j-f1 deleted the rename-jsvalue-wrapper-protocols branch October 2, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename JSValueConstructible and JSValueConvertible
3 participants
@j-f1 @MaxDesiatov @kateinoigakukun