Simplify build system for WASI #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
katei/simplify-build-system
branch
2 times, most recently
from
81a8206 to
08c0561
Compare
|
I checked this branch works well, so it's ready for review: https://github.com/swiftwasm/swift/pull/2736/checks?check_run_id=1900758798 |
MaxDesiatov
reviewed
Feb 15, 2021
MaxDesiatov
reviewed
Feb 15, 2021
MaxDesiatov
reviewed
Feb 15, 2021
| @@ -163,6 +163,18 @@ set_target_properties(Foundation PROPERTIES | |||
| Swift_MODULE_DIRECTORY ${CMAKE_BINARY_DIR}/swift | |||
| INTERFACE_INCLUDE_DIRECTORIES ${CMAKE_BINARY_DIR}/swift) | |||
|
|
|||
| if(NOT BUILD_SHARED_LIBS) | |||
| add_dependencies(Foundation CoreFoundation uuid) | |||
| # TODO(katei): Comment out after swift-frontend implementation | |||
There was a problem hiding this comment.
Could you clarify what implementation are you referring to here?
kateinoigakukun
force-pushed
the
katei/simplify-build-system
branch
from
08c0561 to
ed9c432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
if(NOT CMAKE_SYSTEM_NAME STREQUAL WASI)as much as possible to be accepted for upstream. Use feature flag based building.Don't fetch libxml2 from the source and use CMake package system instead.
LIBXML2_INCLUDE_DIRandLIBXML2_LIBRARYwhen configuring.Fix autolink issue for static library with @_implementationOnly.
-licui18nbecause swift doesn't have a way to add public linking dependencies in module file. likelinkstatement in modulemap.This PR depends on swiftwasm/swift#2733