[pull] swiftwasm from master #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ckCleanup. This cleanup is meant to be used with a value that is temporarily taken from a memory location for a lexical scope. At end of scope, the value is returned back to the original memory location. It is used to implement in SILGen "move only loadable values". Note, a "move only loadable value" is not a "move only type". It is just an abstraction for working with a single copy of a loadable value as if that single copy was a move only value. This is currently only being used in initializer emission since we treat self in such a context as a "move only value" before we delegate to a super/convenience/peer initializer since we have to allow for such initializers to change the underlying class we have stored which in certain use cases require self to be guaranteed as /never/ being retained. The move only value representation makes this easy to do/enforce. My hope is that by changing the name of this cleanup it is more obvious what it is meant to do and can become (hopefully) generally useful.
The correct usage of "-SAME" is after the check-prefix, not in the middle. I've updated the constants to what is emitted today.
[IRGen testing] Fix bogus FileCheck check-prefix "-SAME" usage
…df9168b83d620b32b86f985 [silgen] Rename DelegateInitSelfWritebackCleanup -> OwnedValueWritebackCleanup.
Revert "[IRGen testing] Fix bogus FileCheck check-prefix "-SAME" usage"
We currently leave a key path constraint unsolved if one of its components hasn't yet had its overload resolved. However, for e.g a missing member component, the overload type variable will be bound to a hole and an overload will never be resolved. Tweak the logic to consider the key path constraint trivially solved if one of its components has been marked as a hole, which will allow the key path type itself to be marked as a hole. Resolves SR-12437 & SR-12823. Resolves rdar://62201037.
Lit's incremental mode is incompatible with read-only source filesystems which some CI setups use and there is no way to disable incremental mode in Swift without enabling --shuffle via LLVM_LIT_ARGS.
[CMake] Allow devs to disable implicit incremental testing
…checked_cast_addr
MaxDesiatov
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )