[pull] swiftwasm from master #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Hit this crash while walking an `import protocol ...` declaration. Check loc validity before calling `SourceManager::extractText`: there is an assertion at the beginning of this function. rdar://65258208
@guaranteed args are treated conservatively in ARCSequenceOpts. A function call with a @guaranteed arg is assumed to decrement refcount of the @guaranteed arg. With this change, use swift::mayDecrementRefCount which uses EscapeAnalysis to determine if we need to transition conservatively at the instruction being visited.
rdar://66542551
…ubscripts on tuple base types
…teral within bounds of tuple elements
…tring literals that matches a label of labeled tuples
…numElementPattern
Fix edgecase in AllocBoxToStack handling of local apply
Improve @guaranteed args handling in ARCSequenceOpts
…report-deleted-IDs [Localization] Make the serialization tool print the removed diagnostics
The current "ClangRecordTypeInfo" derives from "LoadableTypeInfo" and is only meant for loadable types. While we have not yet run into problems, this may cause issues in the future and as more logic is needed around copying, moving, and destroying C++ objects, this needs to be fixed.
…ng#33378) We can't actually check for NaN (because the notion doesn't exist for Comparable), but we can require that the endpoint is non-exceptional by checking if it equals itself.
…inout-1 Revert "Sema: Make type resolution for EnumElementPattern less eager"
…8208-crash-invalid-loc-extracttext [SymbolGraph] Check Loc validity before extracting text
…nly dependencies In theory, we shouldn't need to deserialize @_implementationOnly dependencies. However, potential decl recovery issues may bring down lldb if we insist on not importing these dependencies, resulting in bad user experience as a result. This patch adds an internal option to allow importing them and it should only be set by lldb and other tools. rdar://65570721
validateCodingKeysEnum cannot iterate over a hashed collection without ordering guarantees.
This complexity is due to the implementation constraints of Codable synthesis at a time when the type checker could return partially-validated results. This is no longer the case, so all of this code is just technical debt.
The quad-state here is completely superfluous. Break it down into an enum class that encodes the relevant cases we care about and clean up its sole caller.
This more powerful primitive is capable of 1) Detecting invalid classes 2) Detecting invalid superclasses 3) Detecting circularity in inheritance hierarchies The attached crasher demonstrates the reason we need to validate all of these predicates. Simply put, a circular class hierarchy is always going to report the superclass conforms to any protocol with a declaration in the source. Leveraging this, one could construct any circular class hierarchy, and a conformance to Codable would immediately crash because we got as far as trying to build a CodingKeys enum with an absolutely nonsensical structure. This also has the added benefit of de-complecting an enormous amount of codable conformance code. rdar://66588925
Serialization: add an option to allow deserializing @_implementationOnly dependencies
…-no-one-will-be
…-siloptimizer [Disable] SILOptimizer test (66807959)
This specific check has never worked on all processors (because some FP HW mangles NaNs) and recent LLVM changes have broken it on the remaining platforms. Resolves SR-13354
…cript-tuple [SR-13359] [Sema] Tailored diagnostics for missing subscript members on tuple type base
MaxDesiatov
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )