Skip to content

[WASM] Update assertion condition for keypath projector #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

[WASM] Update assertion condition for keypath projector #1634

merged 1 commit into from
Sep 23, 2020

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Aug 28, 2020 •
edited
Loading

This assertion failed when building Tokamak in release mode (version 0.3.0)

Please cherry-pick me into 5.3 branch also.

MaxDesiatov
MaxDesiatov previously approved these changes Aug 28, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Aug 29, 2020
@MaxDesiatov MaxDesiatov merged commit 3c47194 into swiftwasm Sep 23, 2020
@kateinoigakukun kateinoigakukun deleted the katei/fix-keypath-assert branch October 30, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov