[pull] swiftwasm from master #1797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
- Skip the creation of symlinks for the LLVM subprojects. Not needed anymore. - Use `update-checkout.cmd` instead of manually checking out git repositories. - Instead of the focused subset of repositories, `update-checkout` will check all of them, which is not ideal, but the machine network connection is good, so it should not add a lot of delay. - The repositories, however, are cloned without history, which should improve download a little. - Accept new environment variable `REPO_SCHEME` which is passed to update-checkout to be able to use this script for different branches by only changing an enironment variable in the CI server job configuration. By default uses `master` (which will need to be changed soon). - Pass the environment variable `ghprbCommentBody` as a `--github-comment` argument of `update-checkout`, which should checkout the provided PR from GitHub. - Fix the creation of the Clang module cache temporal directory. - Add `PYTHON_HOME` to the path, just in case it is not already there.
When building a curry thunk for unapplied references to instance methods, the type checker would build a CallExpr rather than a DotSyntaxCallExpr to work around various issues with source locations. Fix the underlying issues with source locations in DotSyntaxCallExpr so we can consistently build DotSyntaxCallExpr here, and assert that we don't do this again: * DotSyntaxCallExpr wasn't able to reason about having just one of its children having source location information; fix it. * @dynamicCallable support was passing the declaration source location for the call expression, which was nowhere in the expression itself. The above mistake was covering for this one.
…g-update-checkout [windows] Use update-checkout in build-windows.bat
…ntax-call-source-locs [Type checker] Use DotSyntaxCallExpr consistently for instance members.
kateinoigakukun
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )