[pull] swiftwasm from main #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…e right type expansion rdar://70220886
Concrete types can conform to unavailable protocols because the witness table for the conformance is not required for use with the concrete type itself. However, protocols cannot have unavailable base protocols. I believe this was an oversight of the original implementation here.
…ations Access control, availability and exportability checking missed these because of a baked-in assumption that getGenericParams() == nullptr rules out the presence of a trailing where clause.
This was a no-op and it doesn't make sense in the current model.
…rect_return_results_loadable_by_address LoadableByAddress: Make sure that indirect return arguments are at the right type expansion
…y-fixes Small availability checking fixes
MaxDesiatov
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )