[pull] swiftwasm from main #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
`vadefs.h` is provided by clang, there should be no need to have it in visualc as well
Segregate out a couple of tests that verify changed behaviors in the standard library so we can omit them when testing against older runtimes.
…once. Rather than performing actor isolation checking as part of "miscellaneous" diagnostics on an expression, do it on the whole function at once. This should not change behavior by itself.
Actor isolation checking is going to make use of capture information, so move the computation of captures before both actor isolation checking and effects checking.
Compute the actor isolation for every closure, noting whether it is part of an actor instance (and which 'self' variable describes the instance), global actor, or independent of any actor. This information is required for propertly generating `hop_to_executor` instructions in SIL. Fixes rdar://71126554.
This pass was rewriting branches using the orignal branch target instead of the new branch target. It used to not matter when the pass was mannually splitting critical edges later. Now the splitting is handled automatically. Fixes rdar://71447520 (SILVerifier error after SimplifyCFG "Instruction does not dominate all uses!")
…e-isolation [Concurrency] Annotate closures with their actor isolation.
VisualC: remove unnecessary submodule
Fix SimplifyCFG CheckedCastBrJumpThreading.
Fix back-deployment tests
MaxDesiatov
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )