Skip to content

Don't follow symlink in toolchain bins #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Don't follow symlink in toolchain bins #2344

merged 1 commit into from
Dec 15, 2020

Conversation

kateinoigakukun
Copy link
Member

cp -r follows symlink and copies the actual file contents. So toolchain size has increased.
Use rsync to copy symlink as it is.

MaxDesiatov
MaxDesiatov approved these changes Dec 15, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@kateinoigakukun kateinoigakukun merged commit 16d581f into swiftwasm Dec 15, 2020
@kateinoigakukun kateinoigakukun deleted the katei/dont-follow-symlink branch December 15, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov