[pull] swiftwasm from main #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Clang has decided not to inline certain functions on the refcounting fast paths, so we need to convince it otherwise. rdar://problem/72150908
Because the shims are generally meant for the standard library build, which requires clang, we can default to using the compiler vended information for the types.
Avoid triggering the semantic `IsFinalRequest` and instead check for the presence of the final attribute. Resolves SR-13230.
shims: invert the condition and prefer the clang path
We pass in deadEndBlocks into scCanonicalize's constructor now.
Passing nullptr was undefined behavior because ReborrowVerifier takes a reference to DeadEndBlocks.
[ASTDumper] Don't call isFinal()
…ion-cfg
Specifically, I changed how sil-mode-display-function-cfg searches for the
start/end of the SIL function body where the current point is. Previously, we
just searched for the exact strings "{" and "}" backwards and forwards
respectively. That was insufficient in the context of box types that use those
characters.
Instead with this change, we convert the aforementioned static search to a regex
search. Our regex match "{$" for the beginning of the SIL function and "^} //
end sil function '" or "^}" which I think will generally work to get the correct
body. NOTE: We first check for the end sil function variant.
…487786ad6e7a9a00bbd1329 [sil-combine] Eliminate a dead parameter.
[Incremental Swift Driver] Generalize Driver/Dependencies tests
…ba7f8e2b5479873d3cdb6fa
The one opt we perform here is that we promote fix_lifetime on loadable alloc_stack addresses to fix_lifetimes on objects by loading the underlying value and putting the fix lifetime upon it.
…c4f335da499a0cf60cc44a2 [sil-combine] Update fix_lifetime opts for ownership
rdar://72550007
test: xfail Driver/Dependencies/bindings-build-record.swift
[Runtime] Add SWIFT_ALWAYS_INLINE to various refcounting helpers.
MaxDesiatov
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )