[pull] swiftwasm from main #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…-path flags into the Python build-script"" Also, fix two places where the LLVM path was wrongly employed to set up clang, and use the Swift path in install_toolchain_path().
PR#34895 changed CSE to have common object for OpenedArchetypesTracker and Cloner. CSE however frees and allocates instructions and this can result in the Cloner having stale state for deleted instructions whose address may be re-used while creating new instructions. Using a local object avoids this.
This simply extracts the shared portion of the language version setup. The state of the ObjC interop determines if we are in ObjectiveC or C mode or ObjectiveC++ or C++ mode depending on C++ interop. However, if Objective-C interop is enabled, we must enable ARC and set the ObjC runtime version according to the target. This simply shares more of the setup and is meant as a simplification for pairing the language version.
Fix CSE::processOpenExistentialRef
ClangImporter: unify language standard selection (NFCI)
kateinoigakukun
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )