[pull] swiftwasm-release/5.4 from release/5.4 #2699
Merged
+45
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…on in case of a dealloc_partial_ref If an argument is deallocated in the function, it cannot be converted to a guaranteed argument. We already handled the dealloc_ref instruction, but were missing the dealloc_partial_ref instruction. It fixes a miscompile. rdar://73871606
(cherry picked from commit 5e5a6ca)
(cherry picked from commit fb1f9e4)
[5.4] Disable iOS 32-bit Simulator tests
[5.4] FunctionSignatureOptimization: prevent owned->guaranteed specialization in case of a dealloc_partial_ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )