[pull] swiftwasm-release/5.4 from release/5.4 #2743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…nal<reference> as an operand strong_retain/strong_release with an optional reference as operand are rejected by the verifier and are not supported by IRGen. SILCombine created such retains/releases when optimizing ref_cast instructions. This fixes a compiler crash. rdar://74146617
…ceWritableKeyPaths. Call through to _swift_modifyAtReferenceWritableKeyPath_impl in that case. This fixes an assertion failure (or worse) when upcasting a ReferenceWritableKeyPath and then using subscript(keyPath:) to modify a value with it. rdar://74191390 (cherry picked from commit a84a3a8)
…peAliasDecl with a dependent underlying type Fixes https://bugs.swift.org/browse/SR-11639 / rdar://problem/56466696
…st-5.4 [5.4] SILCombine: don't create a strong_retain/strong_release with an Optional<reference> as an operand
…olved-dmt-fix-5.4 GSB: An unresolved DependentMemberType might resolve to a concrete TypeAliasDecl with a dependent underlying type [5.4]
…eyPath-5.4 [5.4][Stdlib] Fix _swift_modifyAtWritableKeyPath_impl to check for ReferenceWritableKeyPaths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )