Merge SwiftWasm build scripts, thin CMO to 5.4 release #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WASM] Simplify Foundation build script * [WASM] Remove WASI ICU related code from CMake build system * Refactoring build-toolchain script * [WASM] Fix prebuilt libraries path * [WASM] Always install ubuntu wasi-sdk * Fix unarchive command
CMake does not support CMAKE_SYSROOT for Swift yet
|
@yonihemi This compiler crash of Concurrency module can be resolved by merging the latest upstream 5.4 branch, I think. I faced the same crash on the main stream. |
Right |
This reverts commit 50a7f50.
…twasm-release/5.4-tooling
|
@yonihemi Sorry for my slow response 🙇 I think cherry-picking swiftlang#35220 this patch will solve current build failure. |
…@kateinoigakukun] If function pointer is a direct pointer to a function, it could not be an async function pointer. And additive operation to function address is illegal on some archs like wasm32, so emit undefs instead.
…twasm-release/5.4-tooling
|
You need to pick this also 2b7d31b |
|
Thank you @kateinoigakukun! |
kateinoigakukun
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.