[pull] swiftwasm from main #2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…n_by_wrapper If only the init-closure is used and the setter-closure is dead, the argument to the setter partial_apply also needs to be delete - in case it's a load. Otherwise it would cause a memory lifetime failure.
And rename MemoryDataflow -> BitDataflow. MemoryLifetime contained MemoryLocations, MemoryDataflow and the MemoryLifetimeVerifier. Three independent things, for which it makes sense to have them in three separated files. NFC.
The MemoryLifetimeVerifier has to ignore locations with empty types, e.g. and empty tuple. So far, the check for empty types didn't check recursively, so it missed e.g. "((), ())"
It helps to catch more problems
…red-switch-default-warning [ClangImporter] Fix -Wcovered-switch-default warning (NFC)
improvements/fixes in RawSILInstLowering and MemoryLifetimeVerifier
[SR-14282] Compiler crash in DictionaryTrapsObjC.swift
kateinoigakukun
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )