[pull] swiftwasm from main #3663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
We need to be looking at the callee locator here for the recorded IUO unwrap. SR-15249
Add `OverloadChoice::isAnyDynamicMemberLookup`, and use it to clean up a couple of places.
Look at the callee locator to add some additional info to the diagnostic.
Solution application needs to set interface types for variables declared in a `case` statement, otherwise this would lead to crashes in SILGen.
This patch forces the main function to be protected behind MainActor isolation. If no actor isolation is specified, the main function will implicitly have MainActor isolation.
Putting the main function under the MainActor appears to have accidentally "fixed" the resilience tests on Windows. I've put the entry to those tests under a separate task to try and avoid accidentally hiding the bug behind the main actor.
Tests for crashes aren't available on WebAssembly/WASI since there's no way to intercept traps or crashes on this platform. Trapping causes the whole Wasm VM to shut down with no way to recover from within the test code.
[Serialization] Fix merge character artifact
Replace inferrable types before binding literals to contextual type
[ResultBuilders] Make sure that `case` body variables get types
… elts and then perform sub-initialization. Previsouly we were evaluating a tuple elt and then performing the relevant sub-initialization. The problem is that a sub-initialization can invoke code that could perform an early exit cleanup. So any later tuple-elements that may need to be cleaned up along such path will not have had their cleanups initialized, resulting in a leak along such paths. With this commit, we instead evaluate all of the tuple elements and only them perform the sub-initialization ensuring that any early exits clean up all of the tuple elements. rdar://83770295
…SObject." This reverts commit f821a38.
We can't start doing this now.
…-mains Require MainActor isolation on main() function
…f21dca3acd548f55c7bea18 [silgen] When initializing tuples in SILGen, first evaluate all tuple elts and then perform sub-initialization.
…ect-backdeploy Stop re-exporting SwiftNativeNSObject from _Concurrency
MaxDesiatov
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )