[pull] swiftwasm from main #3729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The latest Long Term Support NDK finally removed binutils, including the bfd/gold linkers and libgcc. This simplifies our Android support, including making lld the default linker for Android. Disable three reflection tests that now fail, likely related to issues with swift-reflection-dump and switching to lld. Also, add the libatomic dependency for Android armv7, just as on linux.
Replaced a SmallSetVector worklist with a GraphNodeWorklist to avoid infinitely pushing and popping the same value the same value into and out from the worklist.
Required before fixing/re-enabling OSSA RAUW utilities. Make sure the SILCombine worklist canonicalizes all the copies and guarantees termination. Run canonicalization on every existing copy_value once and once for every new copy_value added during SILCombine. Only add copies and their uses back to the worklist if canonicalization deleted an instruction. Add tracing for sinking forwaring instructions.
Marker protocols don't exist at runtime, drop them when mangling a type for the purposes of runtime type metadata or reflection. Fixes rdar://82314404.
Previously, all phi arguments added to the backedge block were given @owned ownership. That was not correct for arguments that needed to have @guaranteed ownership. Here, that is corrected by using the ownership of the original argument from the header block when adding the phi argument to the backedge block.
SILCombine - Fix worklist logic for OSSA canonicalization
…dagnodeworklist-in-visittransitiveendborrows Used DAGNodeWorklist in visitTransitiveEndBorrows.
…ntime-type-metadata
…tors. Fix a few minor issues in the type checker and SILGen to properly cope with distributed functions defined within extensions of distributed actors. While here, centralize the logic that adds the "_remote_" function. Fixes rdar://84325525.
Distributed thunks were using the same mangling as direct method reference thunks (i.e., for "super" calls). Although not technically conflicting so long as actors never gain inheritance, it's confusing and could cause problems in the future. So, introduce a distinct mangling for distributed thunks and plumb them through the demangling and remangler.
[Test] Remove failing match in SILGen/newtype.swift
…kedge-ownership [LoopRotate] Use ownership for backedge block.
…k-23 Revert "[android] Update to NDK 23"
MaxDesiatov
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )