[pull] swiftwasm-release/5.5 from release/5.5 #3802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Underscores aren't permitted in these identifiers. Fixes rdar://84645973.
…gs on watchOS The asm definition of `swift_async_extendedFramePointerFlags` prevents the use of bitcode with the back-deployment libraries, so remove the definition and use of this symbol from watchOS binaries entirely. Instead, always force the async frame bit to be set. This trades off backtraces on older OS's for debuggability of newer ones. If it causes problems, it can be disabled via the option `-swift-async-frame-pointer=never`. Fixes rdar://84687579.
…ndle-identifier-5.5 Fix embedded plist of back-deployed concurrency library
Introduce a few changes to the logic for watchOS concurrency back-deployment with respect to the async frame pointer. * Only apply the change to watchOS device targets, not simulator targets * Only introduce the override when no specific `-swift-async-frame-pointer=<value>` option is provided on the command line * Only override the default when deploying to watchOS < 8, and * Use "never" for the default rather than "always". This represents a different but safer trade-off than before. Setting the async bit in the frame pointer can cause older APIs (such as backtrace APIs in the OS) to crash when they encounter such frame pointers. So, with this change we never set the bit when back-deploying for watchOS device, to avoid said crashes. The trade-off here is that a back-deployed watchOS app will never have the async frame pointer bit set, so async backtraces will be unavailable even when running on watchOS 8 or newer.
…mepointer-backdeploy-5.5 Disable the definition and use of swift_async_extendedFramePointerFlags on watchOS
MaxDesiatov
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )