Resolve conflicts with upstream main
#3901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not yet used by anything.
This change applies SwiftAttr attributes as soon as possible after creating an instance of a Decl, rather than waiting until the declaration is "finished". That makes sure the attributes can influence the declaration very early in its lifecycle, and in particular, before its conformance table is initialized. Mostly NFC in this commit (other than affecting the order that attributes are printed in), but necessary for future changes in this PR.
...by using `__attribute__((swift_attr("@sendable")))`. `@_nonSendable` will "beat" `@Sendable`, while `@_nonSendable(_assumed)` will not.
This commit also checks if `SwiftAttr` supports `#pragma clang attribute` and, if it does, defines `__SWIFT_ATTR_SUPPORTS_SENDABLE_DECLS` in imported headers so they know they can apply these attributes in an auditing style.
Gives us a place to stuff synthesized declarations for, among other things, imported Clang decls.
An explicit swift_attr("@_nonSendable") will override it (except for ns_error_domain where the type is embedded in another type that's forced to be Sendable), but swift_attr("@_nonSendable(_assumed)") will not.
Move this into a helper function that lives in Sema, avoiding libswiftAST calling into libswiftSema.
This enables the new _StringProcessing module on Windows which was accidentally excluded from the build in swiftlang#40240.
This allows the compiler to parse the Swift swiftinterface file of a recent SDK.
The negative test, which requires that the optimization is not done with an old swift runtime, must run on macos/x86_64. Other platforms don't necessarily have old runtimes. rdar://85519651
Unfortunately using the convenient "bootstrapping0-all", etc. custom targets does not work. For some reason it does not cause a dependent file (like libswift's SIL.o) being rebuilt when a depenency (like swift-frontend from the previous bootstrapping stage) changes. Instead we have to list al library- and executable-targets explicitly.
Otherwise dynamic metadata/conformance lookup does not work.
Use the include search path for the header search rather than constructing the path using relative paths. This is important for getting the interop to work properly as well.
The toolchain has traditionally been buildable with clang, cl (MSVC), and gcc. `__has_feature` is a clang-specific directive, ensure that we are portable to other compilers by providing a definition of the macro incase it is not available (which also includes older clang releases).
SILOptimizer: avoid trawling through the directories for includes
…-one SIL: support non-clang compilers again
utils: update windows builders to include string processing
…commit
[Re-merge] Support __available__((swift_attr("@sendable")))
cmake: three fixes for the libswift build
…9e40580d3e179d450e3cb5c
tests: fix the immortal-arc-elimination.swift test
# Conflicts: # lib/ClangImporter/ClangImporter.cpp
kateinoigakukun
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.