[pull] swiftwasm from main #3940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…meters are initializing. Just something I noticed while reading the code.
…embers. Loading of the members of a C(++) struct/class can occur while doing a direct lookup, so triggering a second direct lookup inside there can introduce a request-evaluator cycle. Reimplement this operation to be more like the way we lazily populate Objective-C classes and protocols, walking through the record members in order and importing their variants, then adding those. This eliminates a bunch of extraneous lookup work, keeps the members in order (see the test case change), and eliminates the potential for cycles.
Non-isolated declarations in general do not require Sendable diagnostics. However, we do need to make sure that `nonisolated let` accesses to actor-isolated state are always cross-actor. Fixes rdar://83371627.
…4c6156940fdd2163c87c530 [mem-access-utils] Teach memInstMustInitialize that indirect out parameters are initializing.
…ce-substitutions
…-without-lookup-direct
…nisolated-check
MaxDesiatov
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )