[pull] swiftwasm from main #3945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
We were not marking the async function pointer as constant but adding it to the `.rdata` section which the Windows linker helped identify as a problem: we were adding data with "rw" to a section that is expected to be "rd". Marking the data as constant results in error propagation breaking (presumably due to failure to materialize parameters properly as bindiff'ing the Concurrency library indicates that the functions are nearly identical with some argument loads elided). This repairs the emission of read/write data into the readonly section.
… in optimize mode rdar://86054209
tests: Temporarily disable Interpreter/struct_extra_inhabitants.swift in optimize mode
tests: disable a flaky AutoDiff test
IRGen: do not mark AFP as const
MaxDesiatov
previously approved these changes
Dec 5, 2021
MaxDesiatov
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )