[pull] swiftwasm-release/5.6 from release/5.6 #4394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…t node, avoiding n^2 append scaling
…rently. With the clarification in SE-0338, revise the definition of "may execute concurrently with" to always be false when we're accessing a value from a same-actor-isolated inner context. Fixes rdar://82004833. (cherry picked from commit 70fa3df)
Fixes rdar://85453819. (cherry picked from commit a6b586d)
…al type metadata. Fixes rdar://88922030. (cherry picked from commit 93703ef)
rdar://89910199 (cherry picked from commit 622ff37)
... because we need to be able to hop to their actors. Fixes rdar://86753732. (cherry picked from commit 1466afc)
… firstSlabBuffer. Creating a task for an async let will attempt to allocate the task in the async let's preallocated space, and if there's any space left over then it will use the extra for the new tasks's allocator. However, StackAllocator requires the preallocated buffer to be large enough to hold a slab header, but the task creation code doesn't check for that. As a result, the task creation code can end up passing a buffer that's too small to hold the slab header. When asserts are enabled, this is caught by an assert. When asserts are not enabled, disaster strikes. We end up computing a negative number for the remaining slab capacity, which underflows to a large positive number, causing the slab to overflow the async let's preallocated space. This results in weird memory corruption. SR-15996 rdar://90357994 (cherry picked from commit adec767)
This effectively reverts swiftlang@6823744 The blanket removal of isolation in default-value expressions had unintented consequences for important workflows. It's still a problem that needs to be addressed, but we need to be more precise about the problematic situations.
…ment() Fixes rdar://problem/90666408.
…aque archetype Fixes rdar://problem/90665615.
RequirementMachine: Narrow fix for concrete type requirements with opaque archetype [5.6]
GSB: Try to avoid calling Type::subst() from expandConformanceRequirement() [5.6]
…kallocator-5.6 [Concurrency] Have StackAllocator gracefully fail when passed a small firstSlabBuffer
…arams-5.6 Ensure that emit unnamed isolated parameters
…-protocol-metadata-5.6 Ensure that we don't emit references to marker protocols in existential type metadata.
…erepr-5.6 Ensure that we print @sendable when printing TypeReprs.
…-not-execute-concurrently-5.6 [SE-0338] Contexts with the same actor isolation never execute concurrently
…plicit Restrict the warning to diagnose only explicit instances of `self` reference that do not mention the parent type via dot syntax e.g. `MyStruct.self`. Resolves: SR-15897 Resolves: SR-15691 Resolves: rdar://90624344 (cherry picked from commit e52c3a0)
…lue-warning 🍒 [5.6] backtrack on part of SE-327 dealing with default-value exprs
5.6: Fix SR-15785 by adding a cached reference to the last linked list node, avoiding n^2 append scaling
[5.6][MiscDiagnostics] Produce warnings about confusable `self` iff its explicit
Cherry-pick a fix for the new failures after SDK update on CI nodes. rdar://90821341
[NFC] Cherry-pick a test fix for new SDK on CI system
MaxDesiatov
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )