Use Yams 5.0.1 to fix Ubuntu 18.04 build #4485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, as can be seen from logs at https://github.com/swiftwasm/swift/runs/6178363121?check_suite_focus=true compilation of Yams fails with this error: ``` /home/runner/work/swift/swift/yams/Sources/Yams/YamlError.swift -Xlinker -soname -Xlinker libYams.so -L /home/runner/work/swift/swift/host-build/Ninja-Release/swiftpm-linux-x86_64/x86_64-unknown-linux-gnu/yams/lib -L /home/runner/work/swift/swift/host-build/Ninja-Release/foundation-linux-x86_64/lib -L /usr/lib/gcc/x86_64-linux-gnu/7 -Xlinker -rpath -Xlinker /home/runner/work/swift/swift/host-build/Ninja-Release/foundation-linux-x86_64/lib: lib/libCYaml.a -ldispatch /home/runner/work/swift/swift/host-build/Ninja-Release/foundation-linux-x86_64/lib/libFoundation.so -lswiftDispatch -lgcc -lgcc_s -lc -lgcc -lgcc_s && : 23585 /usr/bin/ld.gold: error: lib/libCYaml.a(api.c.o): requires dynamic R_X86_64_PC32 reloc against 'yaml_realloc' which may overflow at runtime; recompile with -fPIC 23586 /usr/bin/ld.gold: error: lib/libCYaml.a(scanner.c.o): requires dynamic R_X86_64_PC32 reloc against 'yaml_parser_fetch_more_tokens' which may overflow at runtime; recompile with -fPIC 23587 clang-13: error: linker command failed with exit code 1 (use -v to see invocation) 23588 <unknown>:0: error: link command failed with exit code 1 (use -v to see invocation) ```
|
Have you investigated what change in Yams triggers the linking failure? Does it include something wrong since 4.0.3? |
|
Not yet, but this is on my list. LMK if you'd like to keep this open and resolve the issues in upstream Yams, or if merging this as a temporary fix is fine too. |
|
OK, I've investigated and fixed the issue: jpsim/Yams#353 |
|
The PR has been merged just now 😮 It would be better to wait for the new release. |
|
5.0.1 has been released |
MaxDesiatov
changed the title
|
Ubuntu CI passes now, ready for review |
kateinoigakukun
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, as can be seen from logs at https://github.com/swiftwasm/swift/runs/6178363121?check_suite_focus=true compilation of Yams 5.0.0 fails with this error: