[pull] swiftwasm from main #4496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
As discussed on the forum, `BidirectionalCollection` requirements as currently stated can be interpreted to forbid conforming types from accepting indices that lie between valid (i.e., reachable) indices in the collection. Among other undesirable effects, this interpretation would render SE-0180 (String.Index overhaul) incompatible with these requirements. Update the wording to clarify that the requirements only apply to valid indices. (Collection protocols do not constrain the behavior of invalid indices — it’s up to individual collection types to implement them as they wish.) https://forums.swift.org/t/string-index-unification-vs-bidirectionalcollection-requirements/55946 rdar://92297280
Tidy up the metadata definitions. * Generalize a number of metadata kinds for out-of-process clients * Introduce conveniences to make runtime lookups easier * Introduce TargetExistentialTypeExpression to TrailingObjects stops complaining about OverloadTokens being ambiguous Note that there is no impact on the layout of the metadata - the changes here are all ABI-compatible.
Add requirements to the Builder concept to construct generic signatures and substitution maps. Then introduce a `subst` requirement that uses the substitution map to call through to the builder's notion of type (ref) substitution. This infrastructure is sufficient to model the notion of a RuntimeGenericSignature.
Reconstitute the ExistentialType wrapper around a (parameterized) protocol type. The AST needs to be remodeled here before we can remove this.
Teach Remote Mirrors to read extended existential type metadata.
If we encounter any multi-paylaod enum descriptors with bad data, we can end up writing off the end of the bitmask allocation, causing heap corruption. Add range checks to let us fail gracefully instead. rdar://91423283
The back deployment runtime does not contain the symbols necessary to execute this test. Mark it unsupported.
[nfc] [cxx-interop] Disable `ReadAccessor` benchmark.
[stdlib][docs] Clarify BidirectionalCollection requirements
[RemoteMirror] Add bounds checking to BitMask operations.
Gate Clock Runtime Test on Current Runtimes
[Remote AST] Support Parameterized Existential Types
[AutoDiff][RequirementMachine] Regression test for S4TF RNN/Sequential crasher caused by GenericSignatureBuilder
There's no ambiguity here that can be resolved so just drop it.
Remove Needless Template Dependent Access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )