[pull] swiftwasm-release/5.7 from release/5.7 #4576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
As discussed on the forum, `BidirectionalCollection` requirements as currently stated can be interpreted to forbid conforming types from accepting indices that lie between valid (i.e., reachable) indices in the collection. Among other undesirable effects, this interpretation would render SE-0180 (String.Index overhaul) incompatible with these requirements. Update the wording to clarify that the requirements only apply to valid indices. (Collection protocols do not constrain the behavior of invalid indices — it’s up to individual collection types to implement them as they wish.) https://forums.swift.org/t/string-index-unification-vs-bidirectionalcollection-requirements/55946 rdar://92297280 (cherry picked from commit b8cbd4f)
_RegexParser does not need resilience as it's only ever going to be used by _StringProcessing and RegexBuilder. It's version-locked with its dependent modules. Resolves rdar://93067204.
Properties can also be specified in a protocol/overridden by subclasses, so they should also be classed as "dynamic" in these cases. Removed receiver USRs when *not* dynamic, since it's not used for anything in that case and should be equivalent to the container anyway. Resolves rdar://92882348.
Swiftc port of swiftlang/llvm-project#4207. This introduces a new flag, `-file-prefix-map` which can be used instead of the existing `-debug-prefix-map` and `-coverage-prefix-map` flags, and also remaps paths in index information currently.
Resolves rdar://93080331.
…t part of the AST The code completion might occur inside an attriubte that isn’t part of the AST because it’s missing a `VarDecl` that it could be attached to. In these cases, record the `CustomAttr` and type check it standalone, pretending it was part of a `DeclContext`. This also fixes a few issues where code completion previously wouldn’t find the attribute constructor call and thus wasn’t providing code completion inside the property wrapper. rdar://92842803
(cherry picked from commit 9dd8d3a)
[5.7][SourceKit] Add whether a property is dynamic
…ed_actor_init_local for now (cherry picked from commit ba52537) # Conflicts: # test/Distributed/Runtime/distributed_actor_init_local.swift
Actually slice things in _StringGutsSlice (5.7 cherry pick)
…-in-property-attribute [5.7][CodeCompletion] Support type checking attributes even if they are not part of the AST
…tributed_actor_init_local-5.7 [5.7][wrangler] Unconditionally disable test/Distributed/Runtime/distributed_actor_init_local for now
Conformance Infos for nominal type declarations reference the conforming type by storing an offset to the address in the binary where the type's type descriptor is located. Conformance infos for conformances applied to an extension of a type use a different mechanism: they use an indirect reference to a dynamic symbol, which may be an external symbol **or** a resolved address to a local type descriptor. It is the latter case that the conformance-gather implementation was missing that is added in this PR. Resolves rdar://93578419
[5.7][Parse] Set missing contextual keyword token kind for `async`
[5.7][stdlib][docs] Clarify BidirectionalCollection requirements
…nc-syntax Revert "[5.7][Parse] Set missing contextual keyword token kind for `async`"
…eExtraction [5.7][Static Mirror] Gather local type extension conformance infos correctly
[5.7] Support hermetic indexing information
[5.7] [Regex] Build _RegexParser without resilience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )