[pull] swiftwasm-release/5.7 from release/5.7 #4602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
These don't produce meaningful ParameterLists for this analysis to consider. Bail instead of crashing. rdar://93922410
…ential(s) that would loose generic requirements
Implements SE-0352 revision - require explicit `as` coercion when existential
erasure loses information.
For example:
```swift
protocol P {
associatedtype A
}
protocol Q {
associatedtype B: P where B.A == Int
}
func getB<T: Q>(_: T) -> T.B { ... }
func test(v: any Q) {
let _ = getB(v) // <- produces `any P` which loses A == Int
}
```
No longer test the round trip remapping for the output file - we'll be changing the reader to preserve the canonical output file path instead of converting it back to local. Once all of the changes are complete, we can swap this to verify it is canonical, but indexstore-db will also check this with its own tests.
…-5.7 [5.7][TypeChecker] SE-0352: Require coercion if result type contains exist…
…zation::tryPeephole The callers to ConversionInitialization::tryPeephole assume that, if the conversion peephole succeeded, that the peepholed result was fully emitted into the initialization. However, if the ConversionInitialization sat on top of an in-memory initialization, then tryPeephole would only set the value of the ConversionInitialization, without forwarding the value into the underlying initialization, causing code generation to proceed leaving the underlying memory uninitialized. This problem becomes exposed now when literal closures are emitted with a return value that is indirectly returned and also reabstracted, and the return expression undergoes a ping-pong reabstraction pair: we see through the conversions and peephole away the reabstractions, but fail to emplace the result in the indirect return slot. Fixes rdar://92654098
…9108) [stdlib] Mark NFD and NFC as SPI
…onstraints. When determining whether a superclass conforms to a particular protocol, skip unavailable conformances. This way, we don't minimize away a constraint that might only apply to subclasses of the specified superclass. Fixes rdar://91853658.
When a class has an unavailable conformance to a protocol, do not inherit that unavailable conformance, because it can get in the way of subclasses defining their own (properly-available) conformance. Fixes rdar://89992569.
[5.7] Handle ParamDecls and VarDecls in Argument Matching Diagnostics
…x-5.7 [5.7] SILGen: Complete initialization of FinalContext in ConversionInitialization::tryPeephole
…gtestfix [5.7] Update unit-one-sourcefile-remapped.swift round tripping
…ce-superclass-5.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )