[pull] swiftwasm-release/5.7 from release/5.7 #4615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…tance.setup` FrontendTool sets up diagnostic infrastructure early and suppresses stdout diagnostics if frontend-parseable-output is enabled. It then calls `CompilerInstance.setup` which may fail - if it fails, we exit early. But that means we have not gotten a chance to emit parseable-output. This change moves emission of the `began` parseable message to before `CompilerInstance.setup`, and ensures that a corresponding `finished` message is emitted if the setup fails. Resolves rdar://93187783
…'apply' involves non-root opened archetypes This optimization rewrites only the 'self' argument, and does not know how to substitute types in the users of the given apply instruction in case the underlying protocol method involved `Self`-dependent types. With SE-0309 in motion, the bail-out logic must be generalized to non-root opened archetypes.
…meters and `Self`-rooted type parameters
Synthesized file units were designed for autodiff to emit synthesized declarations, and also to sidestep the design implications of doing so late in the compiler pipeline. A call to materialize synthesized file units was added to the GetImplicitSendable request. This introduced a source of iterator invalidation into forEachFileToTypeCheck in whole-module builds. Any call to insert a new file into the module has the potential to cause the underlying SmallVector to reallocate. This patch provides a narrow workaround that stops using iterators altogether in forEachFileToTypeCheck. However, this bug reveals a severe architectural flaw in the concept of a synthesized file unit. Iterating over the files in a module is an extremely common operation, and there now are myriad ways we could wind up calling a function that mutates the module's list of files in the process. This also means the number and kind of files being visited by compiler analyses is dependent upon whether a request that inserts these files has or has not been called. This suggests the call to ModuleDecl::addFile in FileUnit::getOrCreateSynthesizedFile is deleterious and should be removed. Doing so will come as part of a larger refactoring. rdar://94043340
rdar://93439187
Fix an oversight where syntactic checking was not performed on any statements in a body of a multi-statement after successful solution application. Resolves: rdar://94049113 (cherry picked from commit 953095a)
…s-5.7 [5.7] PerformanceDiagnostics: fix a crash when emitting a module
An `@objc` interface defined from Swift may have a formal type in terms of its Swift bridged types, but we want to lower the SIL-level completion handler implementation according to the actual ObjC types that will be passed at runtime. Fixes rdar://93112430
[5.7][CSClosure] Perform syntactic checks on rewritten statements
[5.7] Patch Out a Source of Iterator Invalidation
…ypes For now, this only works with conformance requirements and not existential types. Fixes rdar://problem/92197412.
…ing type of a typealias Just as with an unconstrained protocol type appearing here, such a typealias can only be used on the right hand side of a conformance requirement, or as the base of an 'any' type.
…n-aka 🍒 [5.7] DiagnosticEngine: Print `any` in 'aka' types
…n-swift-type-bridge-5.7 [5.7] SILGen: Use ObjC types to lower async completion handler arguments.
🍒 [5.7] SE-0309: SILOptimizer fixes & reenable executable tests
…tExit [5.7][Parseable Output] Emit parseable messages on failure in `CompilerInstance.setup`
…nose 🍒[5.7][Distributed] Diagnose missing inout on remoteCall decls
…tocol-improvements-5.7 Parameterized protocol improvements [5.7]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )