[pull] swiftwasm from main #4887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
refering -> referring
`@typeWrapperIgnored` attribute could be used on stored properties of a type wrapped type to exclude them from type wrapper transform.
Using `computeWrappedValueType` is incorrect because that return a type of the wrapped variable and not the *wrapper* variable (one that starts with `_`). Resolves: swiftlang#61017
…ner' Move clangScanningTool and clangScanningService to be parts of 'ModuleDependenciesCache' state, getting rid of the 'ClangModuleDependenciesCacheImpl', which is no-longer needed since we moved moved to by-name lookup of Clang modules.
If a variable with attached property wrapper has an initializer expression it could be modified by implicit wrapper application, if there is no initializer - one would be synthesized by the compiler (without arguments). In both cases target has to be pre-checked before constraints are generated for it. Resolves: swiftlang#61024
Break findInconsistentImportsAcrossFile into two services, one finding inconsistencies across a whole module and a new one finding them across a single file.
[SILGen] Fix typo in SILGenStmt.cpp
…f4495388af69cd65fe0f56a [SIL.rst] Fix warning.
`walkToTypeReprPost` should return `true` to keep walking, so we really want to check if the `offendingType` hasn't been found yet. Otherwise we'll bail as soon as we visit the first type.
Turns out we were getting away with dereferencing `nullptr` in a few cases as `walk` would use `nullptr` to indicate that the walk should be stopped, and luckily Clang didn't optimize it to something broken. This commit is fairly defensive and sprinkles some null checks for calls to `walk` directly on a body of a function or top-level code decl.
Replace the use of bool and pointer returns for `walkToXXXPre`/`walkToXXXPost`, and instead use explicit actions such as `Action::Continue(E)`, `Action::SkipChildren(E)`, and `Action::Stop()`. There are also conditional variants, e.g `Action::SkipChildrenIf`, `Action::VisitChildrenIf`, and `Action::StopIf`. There is still more work that can be done here, in particular: - SourceEntityWalker still needs to be migrated. - Some uses of `return false` in pre-visitation methods can likely now be replaced by `Action::Stop`. - We still use bool and pointer returns internally within the ASTWalker traversal, which could likely be improved. But I'm leaving those as future work for now as this patch is already large enough.
…tOption Add new-driver-only '-explicit-dependency-graph-format=' option
[interop][SwiftToCxx] experimentally expose exposable Swift's Array members to C++
Use the new explicit ASTWalker actions to factor out the skipping logic, ensuring to apply it in post-visitation too, which fixes a PCMacro crash (though I don't believe this is a configuration that ever actually comes up). Also tighten up invariants such that an `IfExpr` must appear within an existing region.
…erated header before it's used first
[Dependency Scanner][NFC] Clean up/Gardening on 'ClangModuleDependencyScanner'
[AST/TypeChecker] TypeWrappers: Add @typeWrapperIgnored attribute
…r-fixes [CSClosure] Fix property wrapper handling
* initial * it works demangling mostly works fix dots printing works add tests add conformance to AnyKeyPath implement SPI subscripts fully work comments use cross platform image inspection remove unnecessary comment fix fix issues add conditional conformance add types try to fix the api-digester test cr feedback: move impls behind flag, remove addChain(), switch statement, fallthrough instead of if-elses, move import cr feedback: refactor switch statement fix #ifdef reindent, cr feedback: removes manual memory management fix missing whitespace fix typo fix indentation issues switch to regexes checks should test in on all platforms print types in subscripts add test for empty subscript Update test/api-digester/stability-stdlib-abi-without-asserts.test Co-authored-by: Xiaodi Wu <13952+xwu@users.noreply.github.com> add commas fix failing test fix stdlib annotation cr feedback: remove global, refactor ifdef cr feedback: switch back to manual memory management switch to 5.8 macro add new weakly linked functions to the allowlist fix one more failing test more cr feedback more cr feedback * fix invisible unicode
[interop][SwiftToCxx] expose generic type traits for C++ types in gen…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )