Add more consts from wasi-libc error.h & seek.h #5079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! I'll fix the CI in the next week and merge this change! |
For SwiftWasm to support wasi features related to reading/writing files and stdin/stderr/stdout we need to be including more code from `swift-corelibs-foundation`. Various functions there rely on consts usually provided by Glibc/Darwin. Add more consts to WASI.swift.gyb to support various code paths in swift-corelibs-foundation's `Sources/Foundation/FoundationErrors.swift` & `Sources/Foundation/FileHandle.swift`.
kateinoigakukun
force-pushed
the
robbert/err-seek-consts
branch
from
dce0838 to
b9c4a02
Compare
kateinoigakukun
force-pushed
the
swiftwasm
branch
from
0630dd3 to
dd5cc56
Compare
kateinoigakukun
approved these changes
Dec 30, 2022
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SwiftWasm to support wasi features related to reading/writing files and stdin/stderr/stdout we need to be including more code from
swift-corelibs-foundation. Various functions there rely on consts usually provided by Glibc/Darwin.Add more consts to WASI.swift.gyb to support various code paths in swift-corelibs-foundation's
Sources/Foundation/FoundationErrors.swift&Sources/Foundation/FileHandle.swift.