[pull] swiftwasm from main #5499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Adds wrapping structs for a bunch of commonly bridged types (but not all the AST nodes yet).
The Swift backtracer's frame pointer unwinder cannot work on Linux without this change, because the compiler omits the frame pointer from the function in libSwift_Backtracing that actually captures the stack. rdar://110260855
For Apple platforms, enable the new stricter boxing semantics only for apps built against the Fall 2023 or later SDK. This avoids breaking apps that relied on the old behavior and have not been updated since then.
When `-unavailable-decl-optimization=complete` is specified obsolete decls should be preserved because their symbols are still ABI since they are available to use when targeting deployment targets earlier than the obsoletion version. Resolves rdar://110268649
…at-for-boxing-semantics [Dynamic Casting] Use old boxing semantics for pre-Fall-2023 apps
…ion should not copy the collection This makes the `CxxConvertibleToCollection` parameter shared, preventing the unnecessary copy of the C++ value. rdar://110110376
…lete-decls SIL: Don't skip lowering obsolete decls
drop_deinit ultimately only affects the semantics of its destroy_value. Avoid generating releases for destroys in which the deinit has been dropped. Instead, individually release the members.
drop_deinit only exists in ownership SIL. Remove IRGen support. A drop_deinit can only ever be destroyed or destructured. A destructure of a struct-with-deinit requires a drop_deinit operand.
to MoveOnlyDeinitDevirtualization
It is not needed for correctness and hides most of the deinit related optimizer bugs.
Many basic SIL passes were silently deleting the struct deinit: - SROA - Mem2Reg - RLE - DSE - FunctionSignatureOpts - LowerAggregates Fixes rdar://109849028 ([move-only] LowerAggregateInstrs eliminates struct deinitialization)
Multiple code motion and ARC related passes were removing struct/enum deinits. Passes fixed include: - SILCombine - EarlyCodeMotion - ReleaseHoisting - *many* passes that rely on ARC analysis (RCIndentity)
Fix a special case in visitReleaseValueInst for enum-with-deinit.
MoveOnlyLoadableStruct should only lower to memberwise destroys if it has no deinit.
The -Onone passes fail to remove struct_extract, so the CHECK lines will fail.
… `borrowing`" This reverts commit 8899d3b.
…modifiers" This reverts commit 87f190b.
…() instead of getASTType() to prevent us from looking through no implicit copy types while serializing. This change makes sense since, in general, when serializing we do not want to look through no implicit copy types since we are trying to 1-1 preserve the SIL.
…h the AST serialization machinery. This looks like a thinko from the early part of the implementation. Without this, the machinery doesn't recognize the layout and just asserts.
…uming/Borrowing. I also added a static_assert to make sure that we always catch this in the future.
…e_addr. The reason why I am using a different instruction for addresses and objects here is that the object checker doesnt have to deal with things like initialization.
…lywrapper_addr. Just the $*T -> $*@moveOnly T variant for addresses. Unlike the object version this acts like a cast rather than something that provides semantics from the frontend to the optimizer.
…r_to_copyable_addr.
[Backtracing][IRGen] Add a semantic attribute to force frame pointer.
…nvertible [cxx-interop] Initializing a Swift.Array from CxxConvertibleToCollection should not copy the collection
[Serialization] Fix serializing CompilerPluginExecutablePaths values
[NFC][ASTGen] Add wrapping structs for commonly bridged types
Fixes rdar://problem/109911237.
…ckTypeVariableCollector
I am going to use this to unwrap ${ @moveOnly T } so that I can pass it to
partial_apply that expect a ${ T }
[move-only] Fix SIL representation and SILOptimizer to preserve value deinits
…on (swiftlang#66379) We introduced shared abstractions for handling the different tags for the other runtime functions, so we should use them here as well.
…a noimplicitcopy type. rdar://108383660
[cxx-interop] add a SWIFT_MUTATING customization macro
Preliminary support for substitution with nested pack expansions
…w-consuming [borrowing/consuming] Make borrowing and consuming parameters no implicit copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )