[pull] swiftwasm from master #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This reduces the dependency on `LLVMSupport`. This is the first step towards helping move towards a local fork of the LLVM ADT to ensure that static linking of the Swift runtime and core library does not result in ODR violations.
Rather than using the forward declaration for the LLVMSupport types, expect to be able to use the full declaration. Because these are references in the implementation, there is no reason to use a forward declaration as the full types need to be declared for use. The LLVM headers will provide the declaration and definition for the types. This is motivated by the desire to ensure that the LLVMSupport symbols are properly namespaced to avoid ODR violations in the runtime.
Reduce the scope of this function since its remaining callers can just make use of type resolution directly.
…ftlang#31669) For accessors: make `AbstractFunctionDecl::getDerivativeFunctionConfigurations` resolve configurations from parent storage declaration `@differentiable` attributes. Fixes "no `@differentiable` attribute" non-differentiability error for accessors whose parent storage declaration `@differentiable` attributes have not been type-checked (e.g. because the storage declarations are in another file). Add protocol requirement and class member storage declaration tests. Resolves TF-1234.
Run clang-format on all differentiation SILOptimizer files. Remove dead commented code.
[NFC] Move resolveIdentifierType from TypeChecker to TypeResolver
…am-requires-class AST: Assert we were given a type parameter in GenericSignatureImpl::requiresClass
Add negative test for SR-12656: differentiation transform crash for opaque result types.
…wiftlang#31675) Remove `llvm::raw_ostream &` argument so that `IndexSubset::dump` can be called in lldb without issue.
runtime: remove `llvm/Support` header usage
runtime: remove use of `swift/LLVM.h` (NFC)
MaxDesiatov
approved these changes
May 9, 2020
kateinoigakukun
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )